Conversation
added 2 commits
October 16, 2025 16:31
Add Automatic name cleaning to UI - meta data creation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds resource name sanitization functionality to the validation system, ensuring resource names comply with required naming patterns. The implementation provides automatic sanitization suggestions and validation to help users create valid resource names.
- Implemented resource name sanitization methods with pattern validation
^[a-z0-9\-_.]+$ - Added comprehensive UI integration for resource name validation with user-friendly error handling
- Enhanced validation workflow to automatically suggest sanitized names for invalid resource names
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| trailpack/validation/standard_validator.py | Added sanitize_resource_name() and validate_and_sanitize_resource_name() methods with pattern validation and automatic suggestion functionality |
| trailpack/validation/README.md | Added documentation section explaining resource name sanitization with examples and usage patterns |
| trailpack/ui/streamlit_app.py | Integrated resource name validation UI with real-time feedback, suggestion acceptance, and reset functionality |
| tests/test_schema_validation.py | Added comprehensive test coverage for resource name sanitization methods and validation integration |
| README.md | Updated workflow description to mention resource name validation feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
don't merge quite yet! |
jakobsarthur
requested review from
l-reitz
and removed request for
TimoDiepers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.